-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reverse engineered ChatGPT API #96
base: main
Are you sure you want to change the base?
Conversation
Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags. |
With regards to the first question, are you stating that merging the code is prohibited due to license issues or the utilization of a reverse-engineered API? Regarding the second question, you are absolutely right. It is preferable to adhere to the "tell, don't ask" principle. I will ensure to modify that section of the code accordingly. Lunjie |
Lunjie |
Hi, @SevaSk,
I hope you're doing well. I wanted to let you know about a PR that I've submitted. It introduces a new feature to ecoute, allowing users to utilize it without the need for a paid OpenAI account. Could you please take a look and provide your feedback?
Thanks,
Lunjie